]> dgit.raspbian.org Git - gnome-shell.git/commit
panel: Don't chain up to parent's allocate
authorFlorian Müllner <fmuellner@gnome.org>
Mon, 29 Apr 2019 17:53:57 +0000 (17:53 +0000)
committerFlorian Müllner <fmuellner@gnome.org>
Mon, 29 Apr 2019 18:29:14 +0000 (18:29 +0000)
commitd57234bec93dc486dac07d6cbc02c52091c5098a
tree8fb80b3f397a1988331e08eceec3490fb7ce7c99
parent38da54fb02cce95ff752cea2793525b9e922c600
panel: Don't chain up to parent's allocate

The top bar handles allocating all its children itself, so there's
little value in chaining up to st_widget_allocate() and get the
default layout manager allocating all children again (and possibly
differently).

If this happens, we end up with an infinite allocation cycle with
corresponding performance penalty. Fix this by just doing and what
Shell.GenericContainer did before commit 286ffbe2b6 replaced it,
and not chain up to StWidget.

Thanks to Robert Mader for debugging the issue.

https://gitlab.gnome.org/GNOME/gnome-shell/issues/1054
js/ui/panel.js